Expose wrapped component through refs.wrapped #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +56,7 @@ module.exports = function createI13nNode (Component, defaultProps, options) { | |||
| */ | |||
| render: function () { | |||
| var props = Object.assign({}, { | |||
| ref: 'wrapped', | |||
There was a problem hiding this comment.
the strategy is good to me, we also did the same thing on some fluxible codes,
https://github.com/yahoo/fluxible/blob/master/packages/fluxible-addons-react/connectToStores.js#L56
https://github.com/yahoo/fluxible/blob/master/packages/fluxible-addons-react/provideContext.js#L45
let's use wrappedElement to keep consistent.
|
👍 just one minor feedback, thanks for PR |
|
CLA is valid! |
890af2b to
19d9312
Compare
|
Thanks @kaesonho, I updated the PR! |
kaesonho
added a commit
that referenced
this pull request
Feb 2, 2016
Expose wrapped component through refs.wrapped
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73