8000 delay detect viewport and store innerHeight by kaesonho · Pull Request #53 · yahoo/react-i13n · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

delay detect viewport and store innerHeight #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2015
Merged

delay detect viewport and store innerHeight #53

merged 1 commit into from
Oct 1, 2015

Conversation

kaesonho
Copy link
Contributor

@lingyan @roderickhsiao @hankhsiao

  1. setImmediate to delay detect viewport, in case we have a whole page switch, we will start to detect viewport right after all component are mounted, which might case heavy CPU usage.
  2. store innerHeight to prevent repaint

@kaesonho kaesonho changed the title delay detect viewport delay detect viewport and store innerHeight Sep 30, 2015
@roderickhsiao
Copy link
Collaborator

👍
Lgtm

@yahoocla
Copy link

CLA is valid!

kaesonho added a commit that referenced this pull request Oct 1, 2015
@kaesonho
Merge pull request #53 from yahoo/delaydetectviewport
3602289 
delay detect viewport and store innerHeight
@kaesonho kaesonho merged commit 3602289 into master Oct 1, 2015
@kaesonho kaesonho deleted the delaydetectviewport branch October 1, 2015 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaesonho @roderickhsiao @yahoocla
0