8000 fix: add event arg and validate pgrep by italux · Pull Request #45 · yahoo/kubectl-flame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add event arg and validate pgrep #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

fix: add event arg and validate pgrep #45

merged 1 commit into from
Feb 25, 2021

Conversation

italux
Copy link
Contributor
@italux italux commented Feb 25, 2021 •
edited
Loading

Fixes #38
Fixes #46

Description

Even after the changes applied on #42 the reported error still happen and this was due to a missing argument (aka --event) and also the validation of the --pgrep

~# date; go build -v -o kube-flame
Thu Feb 25 15:05:29 -03 2021
github.com/VerizonMedia/kubectl-flame/cli/cmd/kubernetes/job
github.com/VerizonMedia/kubectl-flame/cli/cmd/kubernetes

~# date ; ./kube-flame -n namespace pod-name -t 1m --lang python -f /tmp/flamegraph.svg container-name --image verizondigital/kubectl-flame:v0.2.0-python -p uwsgi
Thu Feb 25 15:07:14 -03 2021
Verifying target pod ... ✔
Launching profiler ... ✔
Profiling ... ✔
FlameGraph saved to: /tmp/flamegraph.svg 🔥

@italux italux marked this pull request as ready for review February 25, 2021 18:03
@italux italux mentioned this pull request Feb 25, 2021
Closed
@edeNFed edeNFed merged commit 7b799d0 into yahoo:master Feb 25, 2021
@italux italux deleted the fix/python-job-args branch February 25, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeNFed edeNFed edeNFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug fix from issue added in #42 Error: could not find root process
2 participants
@italux @edeNFed
0