Restoring utils.ErrExit in config tests #2681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +67,7 @@ func resetFlags(cmd *cobra.Command) { | |||
| f.Value.Set(f.DefValue) | |||
| f.Changed = false | |||
| }) | |||
| utils.ErrExit = originalErrExit | |||
There was a problem hiding this comment.
Are we sure resetCmdAndEnvVars and resetFlags are used together can we merge these functions, to also ensure that we change and restore the errExit in a single place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
To avoid validation errors, we override utils.ErrExit.
This PR ensures that the utils.ErrExit is restored after the test, or else it's possible that subsequent test failures are not caught.
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes in callhome/yugabyted payloads? If so, is the payload version incremented?
Does your PR have ch 8000 anges that can cause upgrade issues?