Potential fixes for Restart Required error in automation test #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver retries for restart read required errors with YugabyteDB
27a23f0 to
eaf5809
Compare
… would have set safe time greater than ht_read(snapshot time)
| @@ -169,6 +169,10 @@ main() { | |||
| run_ysql ${TARGET_DB_NAME} "\di" | |||
| run_ysql ${TARGET_DB_NAME} "\dft" | |||
|
|
|||
| # sleep of 1100ms; greater than hearbeat interval either of 1000ms or 500ms(depends on yb version) | |||
| # sleep > max(500, 1000) * n | |||
There was a problem hiding this comment.
Can you put the conclusion of our description either in the PR or in the comment here?
Also, * n ?
There was a problem hiding this comment.
raised a separate PR.
#2629
will close this PR after we have fully concluded.
| - name: "TEST: pg-live-migration-partitions-fall-forward" | ||
| if: ${{ !cancelled() && matrix.test_group == 'live_advanced' }} | ||
| run: migtests/scripts/live-migration-fallf-run-test.sh pg/partitions | ||
| # - name: "TEST: pg-live-migration-partitions-fall-forward" |
There was a problem hiding this comment.
pls uncomment all these test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Potential Fix 1: based on max_clock_skew
Potential fix-2: statement level transaction, easing possibility of server retries for restart read required errors with YugabyteDB
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes in callhome/yugabyted payloads? If so, is the payload version incremented?
Does your PR have changes that can cause upgrade issues?