Tags: y3llowcake/hhvm
Tags
Stub nodes and better average degree computation (facebook#8912) Summary: Adding stub rule: A class is considered a stub class if it doesn't have a parent class. An interface is considered as stub class if it doesn't have any parents. Also, we changed the average degree implementation. The user is providing a degree distribution list instead of avg_width. Hence we can narrow down the search space and speed up the computation. Currently, 500 nodes took 11 minutes, 600 nodes took 25 minutes, 700 nodes took 34 minutes. Refactored the ClingoContext class, encapsulate the ClingoContext into Generator so that we can use a validate method to verify the generated code. Pull Request resolved: facebook#8912 Test Plan: Added test cases for degree distribution and stub classes/interfaces. Given an empty degree distribution, expected to not generating any constraint rules. And given a degree distribution has the total nodes greater than the given number_of_nodes is impossible. Otherwise, the generated code should meet the given constraints. Reviewed By: hgoldstein Differential Revision: D31663112 Pulled By: jamesjwu fbshipit-source-id: 0163cb9c7ff97d4a3f881fc391ead47105c826d6
Stop committing mcrouter codegen (facebook#8918) Summary: Now that we're using thrift's build system instead of a custom one, we have a working `thrift1`, so don't need to commit the codegen. I'm not doing the usual submodule -> externalproject_add thing here as mcrouter - does not use CMake - does not publish regular releases So, this is still going to be more work to update than most dependencies, but at least we're no longer going to need to update the codegen by hand. Pull Request resolved: facebook#8918 Test Plan: lego*, manually built on AWS (not on my mac as mcrouter does not build on MacOS) Differential Revision: D31768051 fbshipit-source-id: 209be0b39d5b3a286d7c31c4791f3ba7264fa236
Skeleton code for decls-to-facts conversion
Summary:
Add an FFI that transforms Decls into Facts
```
unsafe fn hackc_decls_to_facts_cpp_ffi<'a>(
decls: &Decls<'a>,
source_text: &CxxString,
) -> FactsResult;
```
Also add conversation traits to enable the flow "shared Decls" --> "rust Decls" --> "rust Facts" --> "shared Facts", with main logic to be implemented in "rust Decls" --> "rust Facts" stage.
Reviewed By: shayne-fletcher
Differential Revision: D31658146
fbshipit-source-id: 9646b7383ed40f8b80f164a0e7e5d738c88de983
delete THRIFT_IGNORE_ISSET_USE_WARNING_BEGIN/END Reviewed By: yfeldblum Differential Revision: D31551952 fbshipit-source-id: 51e36e13827a4f912beec2cbec0cf49cb6933114
wire up auto_namespace_map in decl parser options Summary: have `hackc_create_direct_decl_parse_options` correctly populate the `auto_namespace_map` member of the result `decl_parser_options::DeclParserOptions`. Differential Revision: D31698207 fbshipit-source-id: 032aca074b51a509247ed2af6d501f868eb894f6
Remove remaining parts of C-style ffi Summary: We ported these types to cxx and no longer need them anywhere Reviewed By: shayne-fletcher Differential Revision: D31692753 fbshipit-source-id: d504d03eea44880730014f812a9803e1efe62a0f
Bump some dependencies for below Summary: Bump in preparation for a new release Reviewed By: brianc118 Differential Revision: D31657479 fbshipit-source-id: eeb2a08c54f6db75b6e515ca0966637f31b906a8
Mark the Native Facts API as pure Summary: A pure function is one that always returns the same result as long as these things are constant: * The HHVM build * HHVM runtime options * The code in WWW In addition, a pure function has no observable side effects - calling a pure function without using its value won't change the output of other functions, pure or otherwise. All functions in the `HH\Facts` namespace fit this definition. I'm not sure if `HH\Facts\extract()` fits this definition, so I didn't mark it as pure. Reviewed By: rodmk, kavoor Differential Revision: D31592571 fbshipit-source-id: eeb41ddb51dbc5436d8742a98cef62523c6306b9
make genPrefetchDir decoupled from typechecking and parse everything Summary: Ever since the change to do files changed since saved state, the job keeps failing on sandcastle. It got me thinking that we really don't need to only parse files changed since last saved state. Parsing is super fast. We can just parse everything and decouple ourselves from the saved state mechanism. This diff does exactly that Differential Revision: D31575902 fbshipit-source-id: 65116d68b05c523ba21df91197348c321bcbb189
Special function support Summary: Special functions like vec(), dict(), keyset(), etc. are all special functions which don't have actual function implementations. Instead they emit special bytecodes in HackC. Therefore, we can/need to support them specially in readonly's case. The good news here is that we can make them polymorphic, which improves the user experience. vec(), dict(), etc will return a readonly collection if their first argument is readonly, and a mutable collection otherwise. Reviewed By: oulgen Differential Revision: D31531162 fbshipit-source-id: 9676afc7de19d72e9044b5e2844286f89f4d7f94
PreviousNext