8000 Change autosave dir to ~/.cache/xournalpp/autosaves by fabian-thomas · Pull Request #3587 · xournalpp/xournalpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change autosave dir to ~/.cache/xournalpp/autosaves #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

fabian-thomas
Copy link
Contributor
  • updated path used in code
  • updated translations

Closes #3348

In the original issue there were two directories for autosaves discussed. ~/.local/share/xournalpp/autosave and ~/.cache/xournalpp/autosave. I decided to go with the cache directory since this would be the first one I would search for autosaves.

I'm pretty sure that I did something wrong with the translation files so please explain me quickly what I've should done with those. Should I've just changed xournalpp.pot and then ran make?

@fabian-thomas
Copy link
Contributor Author
fabian-thomas commented Nov 18, 2021
  • Once this PR gets merged I'm gonna update the website

@bhennion
Copy link
Collaborator

Thanks a lot for the PR (and the others)!

Yeah, you're not supposed to edit the translation files directly. This is done via Crowdin (see here).

You just have to modify the .glade file (or the localized string in any source file). With the new string not yet being translated, it will appear in english in Xournal++, until our translators update it on Crowdin.

So, for the PR, please restore all the .po and .pot files.

@fabian-thomas
Copy link
Contributor Author

Thanks a lot for the PR (and the others)!

Yeah, you're not supposed to edit the translation files directly. This is done via Crowdin (see here).

You just have to modify the .glade file (or the localized string in any source file). With the new string not yet being translated, it will appear in english in Xournal++, until our translators update it on Crowdin.

So, for the PR, please restore all the .po and .pot files.

Done. What should we do about users having their old autosaves in ~/.config/autosave?

@bhennion
Copy link
Collaborator

I don't know. I'm not sure there should be any files left there unless the app crashed. @xournalpp/core, any opinion?

@Febbe
Copy link
Collaborator
Febbe commented Nov 20, 2021

When a file is in the folder, the user is asked if he wants to load it, or, if it should be deleted.

@LittleHuba
Copy link
Member

LGTM! @xournalpp/core merge in 24 hours if there are no objections.

@LittleHuba LittleHuba added the merge proposed Merge was proposed by maintainer label Nov 22, 2021
@bhennion bhennion mentioned this pull request Nov 23, 2021
@bhennion bhennion linked an issue Nov 23, 2021 that may be closed by this pull request
- updated path used in code
- updated translations
@Febbe Febbe force-pushed the autosave_cache_dir branch from eb09eb9 to c735705 Compare November 29, 2021 17:52
@Febbe Febbe merged commit b43ecd9 into xournalpp:master Nov 29, 2021
@Technius Technius added this to the v1.2.0 milestone Dec 22, 2022
rolandlo added a commit to rolandlo/xournalpp that referenced this pull request Sep 13, 2023
In xournalpp#3587 the location for autosave files was moved from the
.config folder to the .cache folder
rolandlo added a commit to rolandlo/xournalpp that referenced this pull request Sep 13, 2023
In xournalpp#3587 the location for autosave files was moved from the
.config folder to the .cache folder
@rolandlo rolandlo mentioned this pull request Sep 13, 2023
Febbe pushed a commit that referenced this pull request Sep 13, 2023
In #3587 the location for autosave files was moved from the
.config folder to the .cache folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge proposed Merge was proposed by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No autosave folder Autosave files belong in user data dir, not user config dir
5 participants
0