-
Notifications
You must be signed in to change notification settings - Fork 888
Change autosave dir to ~/.cache/xournalpp/autosaves #3587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for the PR (and the others)! Yeah, you're not supposed to edit the translation files directly. This is done via Crowdin (see here). You just have to modify the So, for the PR, please restore all the |
Done. What should we do about users having their old autosaves in ~/.config/autosave? |
I don't know. I'm not sure there should be any files left there unless the app crashed. @xournalpp/core, any opinion? |
When a file is in the folder, the user is asked if he wants to load it, or, if it should be deleted. |
LGTM! @xournalpp/core merge in 24 hours if there are no objections. |
db8fd34
to
eb09eb9
Compare
- updated path used in code - updated translations
eb09eb9
to
c735705
Compare
In xournalpp#3587 the location for autosave files was moved from the .config folder to the .cache folder
In xournalpp#3587 the location for autosave files was moved from the .config folder to the .cache folder
In #3587 the location for autosave files was moved from the .config folder to the .cache folder
Closes #3348
In the original issue there were two directories for autosaves discussed.
~/.local/share/xournalpp/autosave
and~/.cache/xournalpp/autosave
. I decided to go with the cache directory since this would be the first one I would search for autosaves.I'm pretty sure that I did something wrong with the translation files so please explain me quickly what I've should done with those. Should I've just changed xournalpp.pot and then ran make?