8000 Fix regressions on master in export dialogs by bhennion · Pull Request #6375 · xournalpp/xournalpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix regressions on master in export dialogs #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

Fix regressions on master in export dialogs #6375

merged 1 commit into from
Apr 12, 2025

Conversation

bhennion
Copy link
Collaborator
@bhennion bhennion commented Apr 6, 2025

While working on #6364, I noticed regressions on master in the export dialogs:

  1. For Export As..., the file chooser did not disappear once the file was selected.
  2. For all export dialogs: the "Do you want to overwrite?" test was not working when typing foobar in the file chooser to
    export to foobar.pdf

This PR fixes those.

@bhennion
Fix regressions on master in export dialogs
d1be9bc 
        * For Export As..., the file chooser did not disappear once the
          file was selected
        * For all export dialogs: the "Do you want to overwrite?" test
          was not working when typing `foobar` in the file chooser to
export to `foobar.pdf`
@bhennion bhennion added this to the v1.3.0 milestone Apr 6, 2025
@bhennion bhennion requested a review from rolandlo April 6, 2025 07:51
@bhennion bhennion added regression This issue is about a regression from the previous release; or this PR fixes a regression. export Issues related to export labels Apr 6, 2025
rolandlo
rolandlo approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member
@rolandlo rolandlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhennion bhennion merged commit b3cd88b into xournalpp:master Apr 12, 2025
6 checks passed
@bhennion
Copy link
Collaborator Author

Thanks for the review!

@bhennion bhennion deleted the pr/exportdialogs branch April 12, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandlo rolandlo rolandlo approved these changes

Assignees
No one assigned
Labels
export Issues related to export regression This issue is about a regression from the previous release; or this PR fixes a regression.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bhennion @rolandlo
0