Unit test for model/StrokeStyle and refactor #4702
Conversation
To ensure we can compare LineStyle in unit test
68fb05c to
ef2f076
Compare
ef2f076 to
b9a29d9
Compare
Fix compile error
|
I have continue making improvement based on this PR in jhilmer#1 should I include them here or keep them as a seperate PR? |
There was a problem hiding this comment.
Overall, this looks like verygood refactoring you did there!
I'd keep it like that and let you do your deeper refactor in a follow up PR.
I made a couple of comments. I'd like for someone else to go over the code before merging though, in case I (we) missed something.
There was a problem hiding this comment.
The code looks good. Nice refactoring!
One thing that could be improved: We want to document functions (and class members) in the header files, not in the source files. For the LineStyle class and the StrokeViewHelper class there is a mix between documenting in header and source file.
Also I have noticed that we don't use HexObjectEncoding anywhere, not even in the tests. So I think we should get rid of it (and also the include in ObjectIOStreamTest.cpp)
|
In the other PR build on top of this one - I have remove |
7745ca5 to
6b7885c
Compare
6b7885c to
a945209
Compare
Tried to first put existing code under unit test and then refactor to use e.g. map, vector, sstring e.g. instead of mix of glib function and new/delete to allocate dynamic arrays.