Plug leaking Stroke in StrokeHandler::strokeRecognizerDetected #4258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rolandlo for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plugs a memory leak happening when the stroke recognizer replaces the stroke.
Esssentially, StrokeHandler::strokeRecognizerDetected clones the recognized stroke (i.e. the result of the recognition process) and adds the clone to the layer. The recognized stroke (not the clone) is then never deleted, and is no longer referenced anywhere once the StrokeRecognizerResult gets deleted.
This PR just removes the clone and directly adds the recognized stroke to the layer (which then owns it).