8000 Crash when entering presentation mode with a small page size · Issue #2943 · xournalpp/xournalpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Crash when entering presentation mode with a small page size #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jneem opened this issue Mar 13, 2021 · 3 comments · Fixed by #5922
Closed

Crash when entering presentation mode with a small page size #2943

jneem opened this issue Mar 13, 2021 · 3 comments · Fixed by #5922
Labels
bug confirmed Bug has been reproduced by at least one other person Crash priority::medium

Comments

@jneem
Copy link
jneem commented Mar 13, 2021

Affects versions :

  • OS: Arch linux repository package, and also latest appimage. (both on X11)
  • gtk 3.24.26
  • Xournal++: 1.0.20-hotfix and latest appimage

Describe the bug

When opening a pdf that has a small page size, if I enter full screen and presentation mode, xournal++ crashes with a SIGSEGV. In particular, I've been able to reproduce this with a pdf for which presentation mode would require more than the maximum 700% zoom.

To Reproduce
Steps to reproduce the behavior:

  1. Open the attached pdf
  2. Enter presentation mode and full screen
  3. crash (if it turns out that the 700% zoom threshold is relevant, this step might depend on your monitor resolution)

xournal-crash.pdf
@jneem jneem added the bug label Mar 13, 2021
@rolandlo rolandlo added confirmed Bug has been reproduced by at least one other person priority::medium labels Mar 13, 2021
@rolandlo
Copy link
Member

Thanks for reporting the bug. In my case I had to use a much smaller pdf to reproduce it. Note that it also depends on your displayDPI settings (in the zoom panel in menu Edit > preferences).
For others to reproduce the bug, use this file: xournal-crash-converted.pdf

All it takes to reproduce the bug is to open the pdf and go into presentation mode.

I am wondering though, what is your screen resolution and what is your displayDPI setting in order to need zoom > 700% for the original document?

@jneem
Copy link
Author
jneem commented Mar 13, 2021

My displayDPI is 72 and my screen resolution is 3840x2400 (it's a big monitor)

@personalizedrefrigerator
Copy link
Contributor
personalizedrefrigerator commented Mar 20, 2021 •
edited
Loading

This looks like a stack overflow to me -- I'm getting a backtrace with more than 120,000 entries...

Here is an excerpt:
Backtrace exerpt

@Technius Technius added the Crash label May 7, 2021
@bhennion bhennion mentioned this issue Dec 25, 2022
Open
6 tasks
bhennion added a commit to bhennion/xournalpp that referenced this issue Oct 6, 2024
@bhennion
Fix xournalpp#2943 - If the presentation mode zoom value is above the…
f5991eb 
… maximal value, we entered an infinte loop
@bhennion bhennion mentioned this issue Oct 6, 2024
Merged
@bhennion bhennion linked a pull request Oct 6, 2024 that will close this issue
Fix crash whenentering presentation mode with tiny page size #5922
Merged
bhennion added a commit to bhennion/xournalpp that referenced this issue Oct 8, 2024
@bhennion
Fix xournalpp#2943 - If the presentation mode zoom value is above the…
639a3c8 
… maximal value, we entered an infinite loop
bhennion added a commit to bhennion/xournalpp that referenced this issue Oct 8, 2024
@bhennion
Fix xournalpp#2943 - If the presentation mode zoom value is above the…
fc048ac 
… maximal value, we entered an infinite loop
bhennion added a commit that referenced this issue Oct 8, 2024
@bhennion
Fix #2943 - If the presentation mode zoom value is above the maximal …
b51995e 
…value, we entered an infinite loop
@bhennion bhennion closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed Bug has been reproduced by at least one other person Crash priority::medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash whenentering presentation mode with tiny page size bhennion/xournalpp
5 participants
@Technius @jneem @bhennion @rolandlo @personalizedrefrigerator
0