8000 BLD: Fix macos and windows build CI by luweizheng · Pull Request #784 · xorbitsai/xorbits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BLD: Fix macos and windows build CI #784

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

BLD: Fix macos and windows build CI #784

merged 3 commits into from
Jun 24, 2024

Conversation

luweizheng
Copy link
Collaborator
@luweizheng luweizheng commented Jun 21, 2024 •
edited
Loading

Fix CI on macos and windows

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.3 milestone Jun 21, 2024
@luweizheng luweizheng changed the title CHORE: exclude macos arm64 when build py39 py310 wheel BLD: fix macos and windows build CI Jun 21, 2024
@luweizheng luweizheng changed the title BLD: fix macos and windows build CI BLD: Fix macos and windows build CI Jun 21, 2024
@codecov Codecov
Copy link
codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.14%. Comparing base (3986478) to head (ade1e5f).

❗ There is a different number of reports uploaded between BASE (3986478) and HEAD (ade1e5f). Click for more details.

HEAD has 8 uploads less than BASE | Flag | BASE (3986478) | HEAD (ade1e5f) | |------|------|------| |unittests|11|3|
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #784       +/-   ##
===========================================
- Coverage   83.31%   31.14%   -52.17%     
===========================================
  Files        1059     1059               
  Lines       79789    79771       -18     
  Branches    16493    16493               
===========================================
- Hits        66476    24845    -41631     
- Misses      11800    54504    +42704     
+ Partials     1513      422     -1091
Flag Coverage Δ
unittests 31.14% <ø> (-52.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qinxuye
qinxuye approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor
@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit e6cea83 into xorbitsai:main Jun 24, 2024
14 of 28 checks passed
@luweizheng luweizheng deleted the build-wheel branch June 24, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
v0.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@luweizheng @qinxuye @XprobeBot
0