8000 FEAT: Add `xorbits.sklearn` module by JiaYaobo · Pull Request #716 · xorbitsai/xorbits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FEAT: Add xorbits.sklearn module #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

FEAT: Add xorbits.sklearn module #716

merged 1 commit into from
Oct 17, 2023

Conversation

JiaYaobo
Copy link
Contributor
@JiaYaobo JiaYaobo commented Sep 24, 2023 •
edited
Loading

What do these changes do?

This PR aims to export xorbits._mars.learn to xorbits.sklearn

Sub-packages has been added ...

  • cluster
  • datasets
  • decomposition
  • ensemble
  • linear_model
  • metrics
  • model_selection
  • neighbors
  • preprocessing
  • semi_supervised

@XprobeBot XprobeBot added this to the 8000 v0.6.3 milestone Sep 24, 2023
@JiaYaobo JiaYaobo marked this pull request as draft September 24, 2023 10:45
@JiaYaobo JiaYaobo changed the title add xorbits.sklearn module [DRAFT] FEAT: Add xorbits.sklearn module Sep 24, 2023
@JiaYaobo JiaYaobo force-pushed the xorbits-sklearn branch 2 times, most recently from e54b7c0 to 13eaad1 Compare September 24, 2023 14:34
@XprobeBot XprobeBot modified the milestones: v0.6.3, v0.7.0 Sep 25, 2023
@JiaYaobo JiaYaobo force-pushed the xorbits-sklearn branch 2 times, most recently from ad7d80b to 60ac88a Compare September 26, 2023 00:18
@JiaYaobo JiaYaobo marked this pull request as ready for review September 26, 2023 00:18
@JiaYaobo JiaYaobo changed the title [DRAFT] FEAT: Add xorbits.sklearn module FEAT: Add xorbits.sklearn module Sep 26, 2023
@codecov
Copy link
codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #716 (e333bcd) into main (c15148d) will decrease coverage by 0.05%.
The diff coverage is 98.93%.

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   82.49%   82.45%   -0.05%     
==========================================
  Files        1026     1058      +32     
  Lines       79589    79777     +188     
  Branches    16497    16503       +6     
==========================================
+ Hits        65657    65779     +122     
- Misses      11655    11700      +45     
- Partials     2277     2298      +21
Flag Coverage Δ
unittests 82.33% <98.93%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/xorbits/sklearn/__init__.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/cluster/__init__.py 100.00% <100.00%> (ø)
.../xorbits/sklearn/cluster/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...thon/xorbits/sklearn/cluster/mars_adapters/core.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/datasets/__init__.py 100.00% <100.00%> (ø)
...xorbits/sklearn/datasets/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...hon/xorbits/sklearn/datasets/mars_adapters/core.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/decomposition/__init__.py 100.00% <100.00%> (ø)
...ts/sklearn/decomposition/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...orbits/sklearn/decomposition/mars_adapters/core.py 100.00% <100.00%> (ø)
... and 22 more

... and 28 files with indirect coverage changes

@JiaYaobo
Copy link
Contributor Author

@aresnow1 @ChengjieLi28 PTAL

@aresnow1
Copy link
Contributor
aresnow1 commented Oct 9, 2023

Could you rebase main branch and push again?

ChengjieLi28
ChengjieLi28 reviewed Oct 9, 2023
View reviewed changes
ChengjieLi28
ChengjieLi28 reviewed Oct 9, 2023
View reviewed changes
@JiaYaobo JiaYaobo requested a review from ChengjieLi28 October 12, 2023 06:51
ChengjieLi28
ChengjieLi28 reviewed Oct 13, 2023
View reviewed changes
@JiaYaobo JiaYaobo force-pushed the xorbits-sklearn branch 2 times, most recently from e9b37a9 to e94571b Compare October 16, 2023 04:23
ChengjieLi28
ChengjieLi28 reviewed Oct 16, 2023
View reviewed changes
@JiaYaobo JiaYaobo requested a review from ChengjieLi28 October 16, 2023 13:14
@ChengjieLi28
Copy link
Contributor
ChengjieLi28 commented Oct 17, 2023 •
edited
Loading

Hi, @JiaYaobo . On Windows os, there are UT failures in the CI.
image

On windows, the numpy 1.26.1 is installed, which was released two days ago.

Please check whether your UT is compatiable with numpy 1.26.1.

@JiaYaobo
add xorbits.sklearn module
e333bcd 
add more sub packages

update

update

update

update

modify

modify

update

update

update

update

update
@JiaYaobo
Copy link
Contributor Author

Hi, @JiaYaobo . On Windows os, there are UT failures in the CI. image

On windows, the numpy 1.26.1 is installed, which was released two days ago.

Please check whether your UT is compatiable with numpy 1.26.1.

numpy 1.26.1 works fine on my macOS, suspecting it's a numpy issue with win32 platform...

codingl2k1
codingl2k1 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor
@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengjieLi28 ChengjieLi28 merged commit 251d1ca into xorbitsai:main Oct 17, 2023
@JiaYaobo JiaYaobo deleted the xorbits-sklearn branch October 18, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingl2k1 codingl2k1 codingl2k1 approved these changes

@ChengjieLi28 ChengjieLi28 Awaiting requested review from ChengjieLi28

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JiaYaobo @aresnow1 @ChengjieLi28 @codingl2k1 @XprobeBot
0