fix edge case where data points are not dominated by the reference point #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- if the reference point is in the non-dominated set then the entire set is not on the PF
- if the reference point is in the non-dominated set then the entire set is not on the PF
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an edge case in the calculation of the Pareto front for MOBOGenerator, ensuring that when the reference point is non-dominated the function returns None.
- Added a new test case in the test suite to verify behavior when all data points are dominated by the reference point.
- Modified the get_pareto_front method to detect the presence of the reference point in the non-dominated set and return None accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| xopt/tests/generators/bayesian/test_mobo.py | Added tests to validate the behavior of the Pareto front when the reference point is present. |
| xopt/generators/bayesian/bayesian_generator.py | Updated logic in get_pareto_front to correctly handle cases with the reference point in the non-dominated set. |
| obj_data = torch.vstack( | ||
| (self.torch_reference_point.unsqueeze(0), objective_data) | ||
| ) | ||
| non_dominated = is_non_dominated(obj_data) | ||
|
|
||
| # get varaible data corresponding to objective data |
There was a problem hiding this comment.
Typo: 'varaible' should be corrected to 'variable'.
Suggested change
| # get varaible data corresponding to objective data | |
| # get variable data corresponding to objective data |
Copilot uses AI. Check for mistakes.
pluflou
approved these changes
Mar 31, 2025
roussel-ryan
added a commit
that referenced
this pull request
Apr 22, 2025
fix edge case where data points are not dominated by the reference point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.