8000 create sequential generator class for RCDS/simplex etc. by roussel-ryan · Pull Request #281 · xopt-org/Xopt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

create sequential generator class for RCDS/simplex etc. #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 5, 2025
Merged

create sequential generator class for RCDS/simplex etc. #281

merged 8 commits into from
Mar 5, 2025

Conversation

roussel-ryan
Copy link
Collaborator
@roussel-ryan roussel-ryan commented Mar 4, 2025 •
edited
Loading
  • create the SequentialGenerator class which is used for sequential optimization algorithms such as RCDS / nelder mead simplex / extremum seeking
  • allows to reset() and start these algorithms from the current data attribute of the generator object
  • prevents users from adding data when the algorithm is running as to not interrupt optimization
  • rewrites RCDS and ES generators to utilize the new base class

@roussel-ryan roussel-ryan mentioned this pull request Mar 4, 2025
Merged
@nikitakuklev
Copy link
Collaborator

This seems a reasonable approach. For adding data, since generators need to customize this, should a _add_data be added for overriding instead of jumping directly to parent class?

@roussel-ryan
Copy link
Collaborator Author

Good idea @nikitakuklev I've added it

nikitakuklev
nikitakuklev approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator
@nikitakuklev nikitakuklev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will adjust the simplex PR once this one is merged.

@roussel-ryan
Copy link
Collaborator Author

great thanks!

@roussel-ryan roussel-ryan merged commit 3fc51d8 into main Mar 5, 2025
14 checks passed
@roussel-ryan roussel-ryan deleted the sequence_generator branch March 5, 2025 22:39
@roussel-ryan
Copy link
Collaborator Author

@shamin-slac

roussel-ryan added a commit that referenced this pull request Apr 22, 2025
@roussel-ryan
Merge pull request #281 from xopt-org/sequence_generator
a27c4a7 
create sequential generator class for RCDS/simplex etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitakuklev nikitakuklev nikitakuklev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roussel-ryan @nikitakuklev @pluflou
0