Don't import coloredlogs if COLOREDLOGS_AUTO_INSTALL is set but empty. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give a tiny performance bump in that case.
|
Kindly bumping? |
|
Hey Antony, thanks for the contribution and sorry for my slow response. I've just merged this pull request and released coloredlogs 11.0 which contains this and other changes. Cheers! |
bors bot
added a commit
to duckinator/bork
that referenced
this pull request
Feb 15, 2020
108: Update coloredlogs to 11.0 r=duckinator a=pyup-bot This PR updates [coloredlogs](https://pypi.org/project/coloredlogs) from **10.0** to **11.0**. <details> <summary>Changelog</summary> ### 11.0 ``` ---------------------------- This is a maintenance release that drops Python 2.6 support, adds Python 3.7 support and merges quite a few minor pull requests. The major version number was bumped because of the compatibility changes. **Merged pull requests:** - `58`_: Don't import :mod:`coloredlogs` if ``$COLOREDLOGS_AUTO_INSTALL`` is set but empty. - `60`_: Fix :pypi:`flake8` messages to help stabilize Travis CI builds. - `61`_: Drop support for Python 2.6 to help stabilize Travis CI builds. - `62`_: Use SVG badge in README for consistency. - `69`_: Handle negative-offset timezones in tests. - `70`_: Use :func:`subprocess.check_call()` in the test suite to ensure that external commands succeed. - `74`_: Fix :exc:`~exceptions.TypeError` on MacOS on Python 3 in the :mod:`~coloredlogs.converter` module. **Other changes:** - Start testing on Python 3.7 (and document compatibility). - Workaround Python 3.7 regression in test suite. - Update ``Makefile`` to use Python 3 for local development. - Merge MacOS on Travis CI fixes from :pypi:`humanfriendly`. .. _Release 11.0: xolox/python-coloredlogs@10.0...11.0 .. _58: xolox/python-coloredlogs#58 .. _60: xolox/python-coloredlogs#60 .. _61: xolox/python-coloredlogs#61 .. _62: xolox/python-coloredlogs#62 .. _69: xolox/python-coloredlogs#69 .. _70: xolox/python-coloredlogs#70 .. _74: xolox/python-coloredlogs#74 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/coloredlogs - Changelog: https://pyup.io/changelogs/coloredlogs/ - Docs: https://coloredlogs.readthedocs.io </details> Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give a tiny performance bump in that case.