feat: Update DOMImplementation according to recent specs
#210
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| 'use strict' | ||
|
|
||
| const { | ||
| DocumentType, | ||
| DOMImplementation, | ||
| Element, | ||
| Node, | ||
| NodeList, | ||
| } = require('../../lib/dom') | ||
|
There was a problem hiding this comment. I would favor that we export and use these from There was a problem hiding this comment. Does it mean you want to land #233 first? Since It currently already has a conflict and I raised two questions there. |
||
|
|
||
| const NAME = 'NAME' | ||
| const PREFIX = 'PREFIX' | ||
| const NS = 'NS' | ||
|
|
||
| describe('DOMImplementation', () => { | ||
| describe('hasFeature (deprecated)', () => { | ||
| it.each(['', '0', 'feature'])( | ||
| "should return true when called with ('%s')", | ||
| (f) => { | ||
| expect(new DOMImplementation().hasFeature(f)).toBe(true) | ||
| } | ||
| ) | ||
| it.each([ | ||
| ['', ''], | ||
| ['0', '1'], | ||
| ['feature', ''], | ||
| ['feature', '1'], | ||
| ])("should return true when called with ('%s', '%s')", (f, v) => { | ||
| expect(new DOMImplementation().hasFeature(f, v)).toBe(true) | ||
| }) | ||
| }) | ||
|
|
||
| describe('createDocument', () => { | ||
| it('should create a Document with basic mandatory arguments', () => { | ||
| const impl = new DOMImplementation() | ||
| const doc = impl.createDocument(null, '') | ||
|
|
||
| expect(doc.nodeType).toBe(Node.DOCUMENT_NODE) | ||
| expect(doc.implementation).toBe(impl) | ||
| expect(doc.doctype).toBe(null) | ||
| expect(doc.childNodes).toBeInstanceOf(NodeList) | ||
| expect(doc.documentElement).toBe(null) | ||
| }) | ||
|
|
||
| it('should create a Document with only a doc type', () => { | ||
| const impl = new DOMImplementation() | ||
| const doctype = impl.createDocumentType('test') | ||
| const doc = impl.createDocument(null, '', doctype) | ||
|
|
||
| expect(doc.doctype).toBe(doctype) | ||
| expect(doctype.ownerDocument).toBe(doc) | ||
| expect(doc.childNodes.item(0)).toBe(doctype) | ||
| }) | ||
|
|
||
| it('should create a Document with root element without a namespace', () => { | ||
| const impl = new DOMImplementation() | ||
| const doc = impl.createDocument(null, NAME) | ||
|
|
||
| const root = doc.childNodes.item(0) | ||
| expect(root).toBeInstanceOf(Element) | ||
| expect(root.ownerDocument).toBe(doc) | ||
| expect(root.namespaceURI).toBe(null) | ||
| expect(root.nodeName).toBe(NAME) | ||
| expect(root.tagName).toBe(NAME) | ||
| expect(root.prefix).toBe(null) | ||
| expect(root.localName).toBe(NAME) | ||
| expect(doc.documentElement).toBe(root) | ||
| }) | ||
|
|
||
| it('should create a Document with root element in a default namespace', () => { | ||
| const impl = new DOMImplementation() | ||
| const doc = impl.createDocument(NS, NAME) | ||
|
|
||
| const root = doc.childNodes.item(0) | ||
| expect(root).toBeInstanceOf(Element) | ||
| expect(root.ownerDocument).toBe(doc) | ||
| expect(root.namespaceURI).toBe(NS) | ||
| expect(root.prefix).toBe(null) | ||
| expect(root.localName).toBe(NAME) | ||
| expect(root.nodeName).toBe(NAME) | ||
| expect(root.tagName).toBe(NAME) | ||
|
|
||
| expect(doc.documentElement).toBe(root) | ||
| }) | ||
|
|
||
| it('should create a Document with root element in a named namespace', () => { | ||
| const impl = new DOMImplementation() | ||
| const qualifiedName = `${PREFIX}:${NAME}` | ||
| const doc = impl.createDocument(NS, qualifiedName) | ||
|
|
||
| const root = doc.childNodes.item(0) | ||
| expect(root).toBeInstanceOf(Element) | ||
| expect(root.ownerDocument).toBe(doc) | ||
| expect(root.namespaceURI).toBe(NS) | ||
| expect(root.prefix).toBe(PREFIX) | ||
| expect(root.localName).toBe(NAME) | ||
| expect(root.nodeName).toBe(qualifiedName) | ||
| expect(root.tagName).toBe(qualifiedName) | ||
|
|
||
| expect(doc.documentElement).toBe(root) | ||
| }) | ||
|
|
||
| it('should create a Document with root element in a named namespace', () => { | ||
| const impl = new DOMImplementation() | ||
| const qualifiedName = `${PREFIX}:${NAME}` | ||
| const doc = impl.createDocument(NS, qualifiedName) | ||
|
|
||
| const root = doc.childNodes.item(0) | ||
| expect(root).toBeInstanceOf(Element) | ||
| expect(root.ownerDocument).toBe(doc) | ||
| expect(root.namespaceURI).toBe(NS) | ||
| expect(root.prefix).toBe(PREFIX) | ||
| expect(root.localName).toBe(NAME) | ||
| expect(root.nodeName).toBe(qualifiedName) | ||
| expect(root.tagName).toBe(qualifiedName) | ||
|
|
||
| expect(doc.documentElement).toBe(root) | ||
| }) | ||
|
|
||
| it('should create a Document with namespaced root element and doctype', () => { | ||
| const impl = new DOMImplementation() | ||
| const qualifiedName = `${PREFIX}:${NAME}` | ||
| const doctype = impl.createDocumentType('test') | ||
| const doc = impl.createDocument(NS, qualifiedName, doctype) | ||
|
|
||
| expect(doc.doctype).toBe(doctype) | ||
| expect(doctype.ownerDocument).toBe(doc) | ||
| expect(doc.childNodes.item(0)).toBe(doctype) | ||
|
|
||
| const root = doc.childNodes.item(1) | ||
| expect(root).toBeInstanceOf(Element) | ||
| expect(root.ownerDocument).toBe(doc) | ||
| expect(root.namespaceURI).toBe(NS) | ||
| expect(root.prefix).toBe(PREFIX) | ||
| expect(root.localName).toBe(NAME) | ||
| expect(root.nodeName).toBe(qualifiedName) | ||
| expect(root.tagName).toBe(qualifiedName) | ||
|
|
||
| expect(doc.documentElement).toBe(root) | ||
| }) | ||
| }) | ||
|
|
||
| describe('createDocumentType', () => { | ||
| it('should create a DocumentType with only a name', () => { | ||
| const impl = new DOMImplementation() | ||
| const doctype = impl.createDocumentType(NAME) | ||
|
|
||
| expect(doctype).toBeInstanceOf(Node) | ||
| expect(doctype).toBeInstanceOf(DocumentType) | ||
| expect(doctype.nodeType).toBe(Node.DOCUMENT_TYPE_NODE) | ||
| expect(doctype.name).toBe(NAME) | ||
| expect(doctype.publicId).toBe('') | ||
| expect(doctype.systemId).toBe('') | ||
| }) | ||
|
|
||
| it('should create a DocumentType with name, publicId and systemId', () => { | ||
| const impl = new DOMImplementation() | ||
| const doctype = impl.createDocumentType(NAME, '"PUBLIC"', '"SYSTEM"') | ||
|
|
||
| expect(doctype.name).toBe(NAME) | ||
| expect(doctype.publicId).toBe('"PUBLIC"') | ||
| expect(doctype.systemId).toBe('"SYSTEM"') | ||
| }) | ||
| }) | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous implementation left the definition of features and versions that are supported to the code that calls the constructor, which doesn't make any sense at all. This was one more reason why I decided to not keep or fix it, but to implement it as it is specified in the living standard.