8000 fix: correct spelling of `isHTMLMimeType` in type definition by marvinruder · Pull Request #715 · xmldom/xmldom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correct spelling of isHTMLMimeType in type definition #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: correct spelling of isHTMLMimeType in type definition #715

merged 1 commit into from
Aug 30, 2024

Conversation

marvinruder
Copy link
Contributor

@marvinruder
Fix spelling of isHTMLMimeType in type definition
8000
7c0a038 
* Fixes #712

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
karfau
karfau approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member
@karfau karfau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot

@karfau karfau added bug Something isn't working types Anything regarding Typescript labels Aug 30, 2024
@karfau karfau added this to the 0.9.1 milestone Aug 30, 2024
@codecov Codecov
Copy link
codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (b1f133c) to head (7c0a038).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files           8        8           
  Lines        2094     2094           
  Branches      537      537           
=======================================
  Hits         1974     1974           
  Misses        120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karfau karfau changed the title Fix spelling of isHTMLMimeType in type definition fix: correct spelling of isHTMLMimeType in type definition Aug 30, 2024
@karfau karfau merged commit 3f570aa into xmldom:master Aug 30, 2024
38 checks passed
@vasmiheich vasmiheich mentioned this pull request Sep 26, 2024
Open
@noushiyo noushiyo mentioned this pull request Sep 26, 2024
Open
This was referenced Sep 26, 2024
Closed
Closed
@idleberg idleberg mentioned this pull request Sep 26, 2024
Open
@Soontao Soontao mentioned this pull request Sep 26, 2024
Open
@deepakprabhakara deepakprabhakara mentioned this pull request Sep 27, 2024
Closed
@ITSecOps-404 ITSecOps-404 mentioned this pull request Oct 5, 2024
Open
@1AhmedYasser 1AhmedYasser mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karfau karfau karfau approved these changes

Assignees
No one assigned
Labels
bug Something isn't working types Anything regarding Typescript
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

Difference in spelling of isHTMLMimeType between implementation and type definition
2 participants
@marvinruder @karfau
0