SamplePool adapter #544
SamplePool adapter #544
Conversation
|
Partially solves #547 |
|
Sample import seems to be broken:
|
There was a problem hiding this comment.
Looking good! I tested this with a wide variety of sample sizes and couldn't get it to hang/crash as happened when previously I removed the timing workaround so I think this reorg of code is avoiding that issue. 👍🏻
I had a few naming/types nitpicks but they can be cleaned up later
|
@democloid one not so good consequence of these changes is it stops the flash loading from #534 from working so now we get a long pause for big samples after they get to 100% (of the file copying part of the import) until the flashing completes. Not sure why this is happening, is something different now about how the core lockouts work? |
We are not entirely sure why this worked in the first place, as I said before we wanted to implement this, it shouldn't have worked. The fact that it did may indicate some issue with the lockout or interrupt disable which was not working and thus interrupts still working in some core and rendering this. I'll land this as is and we can discuss later how to solve the issue, since at the end of the day, we want things working as expected. |
Move sample pool load method into specific platform implementation. Tweaked methods a bit, doesn't seem to require the wait hack, but not sure where did this manifest.