Add 1Hz clock tick & use it for batt gauge updates #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voltage levels based on recording batt voltage during a run down test
democloid
requested changes
Feb 16, 2024
Closed
maks
commented
Feb 18, 2024
eg we draw the batt during normal screen redraws when user move cursor as well as every 1 (sec) clock tick
democloid
approved these changes
Feb 27, 2024
djdiskmachine
pushed a commit
to djdiskmachine/picoTracker
that referenced
this pull request
Apr 3, 2024
clock tick initially used for batt gauge updates
maks
added a commit
that referenced
this pull request
Oct 23, 2024
* "electric piano" init patch for opal instruments * fix algo display vals, only support 2OP FM * fix bug in setting operator output levels * fix to use currently playing note for note-Off opal cmd * add Gate-off cmd support to OpalInstrument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
OnClockTick()callback method available to implemented by all View sub classes that gets called from the main loop at approximately 1Hz, allowing UI code that needs to update at a regular rate. As an example, the first usage of this is the newly added battery gauge on the Song screen. Eventually it should likely be on every screen and so should move to the View parent class.This also slightly relocates the battery gauge to the top line to be more nicely layed out as it can now be shown when the playback UI next to it is not when project is not playing back.
Unfortunately this is quite invasive change as all View sub classes now need to declare at least a virtual empty impl of the new callback method.
Note: currently this is stacked on the prev PR branch that adds the battery gauge.
Fixes: #129