8000 qt: don't dereference error if there is no error by hsitter · Pull Request #701 · ximion/appstream · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

qt: don't dereference error if there is no error #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qt: don't dereference error if there is no error #701

wants to merge 1 commit into from

Conversation

hsitter
Copy link
Contributor
@hsitter hsitter commented Mar 9, 2025

blind fix for https://bugs.kde.org/show_bug.cgi?id=500691

not sure it even builds :)

@ximion
Copy link
Owner
ximion commented Mar 16, 2025

Good in theory, but I thought this API was changed with the 1.0 release to behave a bit more predictably, where a FALSE return actually means "The error is set". I'll have a look if this can be fixed in a better way without an API break (if it isn't fixed already), but if not, we'll probably have to use this patch...

ximion added a commit that referenced this pull request Apr 14, 2025
@ximion
trivial: Improve async pool loading code a little
0b8bab2 
CC: #701
@ximion
Copy link
Owner
ximion commented Apr 14, 2025

Is there any way I can reproduce this issue? I haven't managed to do that yet and there is no possible way for the function to return an empty error while also returning FALSE.
I reviewed that code, and there is no code path to that that I found. The patch to the Qt bindings papers over a potential issue elsewhere, and I would much rather find the root cause of the problem.

Also, knowing the versions of appstream and libxmlb that the reporter used would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug incomplete qt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsitter @ximion
0