8000 JDK21 build problem with gmake: Makefile contains '-source 1.7' and '-target 1.7' · Issue #532 · xerial/snappy-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JDK21 build problem with gmake: Makefile contains '-source 1.7' and '-target 1.7' #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blacklion opened this issue Oct 25, 2023 · 3 comments · May be fixed by #663
Open

JDK21 build problem with gmake: Makefile contains '-source 1.7' and '-target 1.7' #532

blacklion opened this issue Oct 25, 2023 · 3 comments · May be fixed by #663

Comments

@blacklion
Copy link

Makefile still contains:

$(TARGET)/jni-classes/org/xerial/snappy/SnappyNative.class: $(SRC)/org/xerial/snappy/SnappyNative.java
	@mkdir -p $(TARGET)/jni-classes
	$(JAVAC) -source 1.7 -target 1.7 -h $(SRC)/org/xerial/snappy/ -d $(TARGET)/jni-classes -sourcepath $(SRC) $<

$(SRC)/org/xerial/snappy/SnappyNative.h: $(TARGET)/jni-classes/org/xerial/snappy/SnappyNative.class

$(TARGET)/jni-classes/org/xerial/snappy/BitShuffleNative.class: $(SRC)/org/xerial/snappy/BitShuffleNative.java
	@mkdir -p $(TARGET)/jni-classes
	$(JAVAC) -source 1.7 -target 1.7 -h $(SRC)/org/xerial/snappy/ -d $(TARGET)/jni-classes -sourcepath $(SRC) $<

It fails with JDK21, as 1.7 is deprecated.
@blacklion
Copy link
Author

I've checked, and build with -source 8 -target 8 works, though with warnings about future removal of these options too.

@xerial
Copy link
Owner
xerial commented Nov 23, 2023

Good cath. Targeting JDK8 should be no problem. Whenever you have time, I'd appreciate a PR for the fix.

@VVD
Copy link
VVD commented Jul 16, 2024

With this patch build for me too on OpenJDK 21.0.3+9.1, FreeBSD 14.1 amd64.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jul 26, 2024
@VVD
archivers/snappy-java: support build with OpenJDK 21
e4f0d70 
In Java 21 compiler removed support for source and target 1.7 (7).

PR:		280316
Approved by:	Angelo Polo <language.devel@gmail.com>
Obtained from:	xerial/snappy-java#532
jdbp-classpass added a commit to jdbp-classpass/snappy-java that referenced this issue May 7, 2025
@jdbp-classpass
Change -source and -target parameters to Java 8
54ce311 
This will allow snappy-java to build with JDK 21.

Resolves xerial#532
@jdbp-classpass jdbp-classpass linked a pull request May 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change -source and -target parameters to Java 8 jdbp-classpass/snappy-java
3 participants
@xerial @blacklion @VVD
0