fix: formatting for text nodes #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Manuel <30698007+manuel3108@users.noreply.github.com>
🦋 Changeset detectedLatest commit: e5fb9ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ho91/js-ast into fix/formatting-for-text-nodes
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
|
xeho91
reviewed
Jun 1, 2025
| `; | ||
| const node = parse_and_extract<AST.Fragment>(code, "Fragment"); | ||
| expect(printFragment(node).code).toMatchInlineSnapshot(` | ||
| "{#snippet template({ children, ...args }: Args<typeof Story>, context: StoryContext<typeof Story>)} | ||
| " |
There was a problem hiding this comment.
Intentional. I'm not touching whitespace characters if we're to use printFragment() directly.
It's only being removed from the printRoot() and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently have no clue at the codebase, thus decided to add some failing tests in the meantime. Happy to work on it if you give me a few hints.
Noticed while trying to include
svelte-ast-printintosvfor a POC