Update schema.json to correctly describe the 'alter column' operation
#261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SferaDev
reviewed
Feb 1, 2024
SferaDev
reviewed
Feb 1, 2024
|
I think we should add some tests around schema validation for the 'alter column' operation here too. |
|
I pushed another update to the schema - it fixes the problem where |
Describe which fields are required and which are optional.
de5e39c to
18a1955
Compare
|
I've added some tests for JSON schema validation in #263 |
exekias
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
schema.jsonto correctly describe the 'alter column' operation.The alter column operation is used to perform different alter column operations according to which fields are present.
The rules are:
tableandcolumnare always required.name,type,check,unique,references,nullablemust be present.type,check,unique,referencesornullableis present, thenupanddownmust also be present.nameis present then neitherupordownis allowed.This PR updates
schema.jsonto capture these dependencies.This change causes churn in the test code as some fields that previously
stringhave become*string.Fixes #222