Dont require database access to pgroll latest --local
#760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request decouples database access from the local "latest" command by converting LatestVersionLocal into a standalone function that operates only on local migration files.
- Removed the receiver from LatestVersionLocal and updated its usage in tests.
- Updated the latest command implementation to use separate helper functions for local and remote version retrieval.
- Adjusted error messages in the command for clearer context.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/roll/latest_test.go | Updated tests to use the new standalone LatestVersionLocal |
| pkg/roll/latest.go | Converted LatestVersionLocal from a method to a function |
| cmd/latest.go | Refactored command logic to handle local and remote modes |
Comments suppressed due to low confidence (1)
cmd/latest.go:60
- Consider wrapping the error returned by os.Stat with additional context (e.g., "failed to stat directory") to improve clarity compared to the previous version.
return "", err
27badf0 to
670a27d
Compare
|
rebased to resolve a merge conflict |
kvch
reviewed
Mar 27, 2025
`LatestVersionLocal` is a function that doesn't need to be a method of the `Roll` type. It can be a package-level function instead.
Ensure that the `latest` command does not require database access when the `--local` flag is provided. In this case the command should act locally, with the migrations on disk and not require a connection to the database.
670a27d to
4f7373a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
latestcommand does not require database access when the--localflag is provided.In this case the command should act only locally, with the migrations on disk and not require a connection to the database.
The reason it used to require a DB connection was to support the
--with-schemaflag which took the schema name from an instantiatedRollinstance. Change this so that the schema name is instead taken from the command line--schemaflag (or thePGROLL_SCHEMAenv var) directly instead.Fixes #726