sql2pgroll: Ignore IF NOT EXISTS in CREATE INDEX statement conversion
#759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `CREATE INDEX IF NOT EXISTS` statements to `create_index`
operations as though the `IF NOT EXISTS` clause was not present.
A `CREATE INDEX` statement like this:
```sql
CREATE INDEX IF NOT EXISTS "name" ON "dogs" USING btree ("name");
```
is now converted to:
```json
{
"operations": [
{
"create_index": {
"columns": {
"name": {}
},
"method": "btree",
"name": "name",
"table": "dogs"
}
}
8000
]
}
```
rather than a raw SQL migration.
See the discussion on #719 for
the rationale behind this change.
kvch
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
CREATE INDEX IF NOT EXISTSstatements tocreate_indexoperations as though theIF NOT EXISTSclause was not present.A
CREATE INDEXstatement like this:is now converted to:
{ "operations": [ { "create_index": { "columns": { "name": {} }, "method": "btree", "name": "name", "table": "dogs" } } ] }rather than a raw SQL migration.
See the discussion on #719 for the rationale behind this change.
Fixes #719 and #720