Implement dropping functions as DBAction
#750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04088d9 to
e894d84
Compare
e894d84 to
bba03e2
Compare
bba03e2 to
13fb531
Compare
Comment on lines
194
to
196
| for i, j := 0, 0; i < len(o.Columns); i, j = i+1, j+2 { | ||
| dropFuncs[j] = pq.QuoteIdentifier(TriggerFunctionName(o.Table, o.Columns[i])) | ||
| dropFuncs[j+1] = pq.QuoteIdentifier(TriggerFunctionName(o.Table, TemporaryName(o.Columns[i]))) | ||
| dropFuncs = append(dropFuncs, TriggerFunctionName(o.Table, o.Columns[i])) | ||
| dropFuncs = append(dropFuncs, TriggerFunctionName(o.Table, TemporaryName(o.Columns[i]))) |
There was a problem hiding this comment.
Don't need i, j, can just range over o.Columns:
for _, column := range o.Columns {
dropFuncs = append(dropFuncs, TriggerFunctionName(o.Table, column))
dropFuncs = append(dropFuncs, TriggerFunctionName(o.Table, TemporaryName(column)))
}
13fb531 to
1bc3aef
Compare
andrew-farries
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new action to drop one or more functions in a single database action.