8000 Use `license-header-checker` locally to add missing license headers by kvch · Pull Request #748 · xataio/pgroll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use license-header-checker locally to add missing license headers #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2025
Merged

Use license-header-checker locally to add missing license headers #748

merged 2 commits into from
Mar 26, 2025

Conversation

kvch
Copy link
Contributor
@kvch kvch commented Mar 25, 2025

Copilot removes the license headers from some files. I added a make target for adding the license headers back to these files. Or just to add it to new files.

The target uses the same binary we leverage in GH actions.

@kvch kvch requested a review from andrew-farries March 25, 2025 14:25
@github-actions github-actions bot temporarily deployed to Docs Preview March 25, 2025 14:25 Inactive
andrew-farries
andrew-farries reviewed Mar 25, 2025
View reviewed changes
Copy link
Collaborator
@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an empty file; add_license_header.sh committed as part of this PR that should be removed.

We should update the GH actions workflow so that it runs make license too rather than duplicating the same steps.

@kvch kvch force-pushed the kvch/add-license-header-script branch from 1f9cc7a to fb73d06 Compare March 25, 2025 17:15
@github-actions github-actions bot temporarily deployed to Docs Preview March 25, 2025 17:15 Inactive
@kvch kvch merged commit ebe6f78 into main Mar 26, 2025
30 checks passed
@kvch kvch deleted the kvch/add-license-header-script branch March 26, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvch @andrew-farries
0