Alter sequence owner before dropping the column #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c5d4219)
kvch
requested changes
Feb 10, 2025
There was a problem hiding this comment.
This is a good start. But unfortunately, the bug can surface in all migration types if the column that has a serial sequence is being duplicated. Thus, it is not enough to change the owner only in create constraint operation. The issue must be addressed in more migration types where RenameDuplicatedColumn is called. The function that does the ownership change could be moved to duplicate.go or rename.go.
kvch
requested changes
Feb 11, 2025
kvch
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there's any sequence for the column before dropping it. If the column type is serial,
pg_get_serial_sequencewill return the sequence name. With this PR, we will be changing the owner column of the seqeunce to the new column so that we can safely drop the old one.Fixes: #633