Add support for alter_table set NOT NULL operations with create_table operations
#608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Jan 20, 2025
508a839 to
60e201c
Compare
03f78a6 to
632f47c
Compare
Record the type of the columns in the new table in the in-memory schema representation built by `OpCreateTable`. This ensures that a columns can be duplicated correctly if a following operation in the same migration needs to duplicate the column.
632f47c to
ce2b4dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that multi-operation migrations combining
alter_columnSET NOT NULLandcreate_tableoperations work as expected.{ "name": "06_multi_operation", "operations": [ { "create_table": { "name": "items", "columns": [ { "name": "id", "type": "serial", "pk": true }, { "name": "name", "type": "text", "nullable": true } ] } }, { "alter_column": { "table": "items", "column": "name", "nullable": false, "up": "SELECT CASE WHEN name IS NULL THEN 'anonymous' ELSE name END", "down": "name || '_from_down_trigger'" } } ] }This migration creates a table and then sets a column's
nullability.Previously the migration would fail as the
alter_columnoperation was unaware of the changes made by the preceding operation.Part of #239