New option for columns: generated
#605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Farries <andyrb@gmail.com>
…ataio#603) Remove the ability to rename columns with `alter_column` operations. xataio#602 added the `rename_column` operation as the preferred way to rename columns: ```json { "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] } ``` As of this PR, `rename_column` operations are the only way to rename columns, with the ability to do so using `alter_column` operations removed. This is a breaking change to the `pgroll` migrations format. This is the second (and final) part of xataio#601 Closes xataio#601
|
Converting into draft until required changes are merged in https://github.com/xataio/pg_query_go. |
|
|
andrew-farries
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generated columns in
create_tableandadd_columnoperations.The column definition is extended with the setting named
generated.Define a stored column:
Define a generated identity column:
Identity columns are marked not null by default, so setting
nullableis unnecessary.I changed the existing
fruitstable to use a generated identity column as a primary key.{ "name": "08_create_fruits_table", "operations": [ { "create_table": { "name": "fruits", "columns": [ { "name": "id", "type": "bigint", "pk": true, "generated": { "identity": { "user_specified_values": "BY DEFAULT" } } }, { "name": "name", "type": "varchar(255)", "unique": true }, { "name": "price", "type": "decimal(10,2)" } ] } } ] }The PR also contains the transformation required by
sql2pgrollproject.Requires xataio/pg_query_go#7