8000 Add pg type type info to schema by agedemenli · Pull Request #592 · xataio/pgroll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add pg type type info to schema #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

< 8000 /details>
Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add pg type type info to schema #592

merged 2 commits into from
Jan 15, 2025

Conversation

agedemenli
Copy link
Contributor
@agedemenli agedemenli commented Jan 14, 2025 •
edited
Loading

Adding PostgresType into read_schema output and filling it with info obtained from typtype column of pg_catalog.pg_type. Adding a test with different type types and fixing the already existing ones.

partially fixes #385

for reference:

typtype char
typtype is b for a base type, c for a composite type (e.g., a table's row type), d for a domain, e for an enum type, p for a pseudo-type, r for a range type, or m for a multirange type. See also typrelid and typbasetype.

from: https://www.postgresql.org/docs/current/catalog-pg-type.html#CATALOG-PG-TYPE

@agedemenli agedemenli force-pushed the add-typtype-info-to-schema branch 2 times, most recently from aeeef05 to 5f7a490 Compare January 14, 2025 13:04
@agedemenli agedemenli marked this pull request as ready for review January 14, 2025 13:09
@agedemenli agedemenli force-pushed the add-typtype-info-to-schema branch from 5f7a490 to 387e0ca Compare January 15, 2025 08:57
@agedemenli agedemenli mentioned this pull request Jan 15, 2025
Closed
andrew-farries
andrew-farries approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator
@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

@agedemenli agedemenli merged commit cb0c1e2 into main Jan 15, 2025
28 checks passed
@agedemenli agedemenli deleted the add-typtype-info-to-schema branch January 15, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

@ryanslade ryanslade Awaiting requested review from ryanslade

@exekias exekias Awaiting requested review from exekias

@kvch kvch Awaiting requested review from kvch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More information in /schema about column types.
2 participants
@agedemenli @andrew-farries
0