Multi-operation migration support for add_column operations
#590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_column migrationsadd_column operations
kvch
approved these changes
Jan 14, 2025
Ensure that it's possible to create a table and add a column to it in the same migration.
Remove this test because it is similar to the parent commit. The test in the parent commit subsumes this one and forces a test failure; this one passes as written.
Make `OpCreateTable` add the details of the new table's primary key to the virtual schema. This allows subsequent `Start` or `Validate` methods of operations in the same migration to reference the table's primary key. For example, this change allows the `OpAddColumn.Validate` operation to know that if the new table has a primary key that can be used for a backfill.
Ensure that it's possible to add a column to a table that was renamed by a previous operation in the same migration.
When creating the trigger take the table name from the schema instead of the operation. This is because a preceding rename table operation may have renamed the table, so looking the name up in the schema accounts for any indirections that may have occurred.
When rolling back the operation, take the name of the table from the schema instead of the operation. A preceding rename table operation may have renamed the table, so looking up the table by name in the schema accounts for any indirections.
Ensure that the a column with the same name can't be added to the same table twice in one migration.
a0c5c62 to
2733675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please ch
2B98
eck back later.
Ensure that
add_columnoperations can be used as part of multi-operation migrations:Add testcases for:
Theses changes help ensure that
add_columnoperations can be used as part of multi-operation migrations.Part of #239