Add support for creating partial indexes on tables #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
reviewed
Oct 15, 2024
Co-authored-by: Ryan Slade <ryanslade@gmail.com>
exekias
reviewed
Oct 16, 2024
There was a problem hiding this comment.
This looks good 👍
We should also update the read_schema SQL function to return information about the predicate of a partial index. Right now the new index from the example looks like this:
{
"indexes": {
"idx_fruits_id_gt_10": {
"name": "idx_fruits_id_gt_10",
"unique": false,
"columns": [
"id"
]
}
}
}
(this is part of the resulting_schema field after the migration to add the partial index has been applied).
The previous version was building the pgroll command before every example run. Instead, build the command once at the beginning and remove it at the end.
Closes xataio#257 --------- Co-authored-by: Andrew Farries <andyrb@gmail.com>
|
Updated the PR so the output of "idx_fruits_id_gt_10": {
"name": "idx_fruits_id_gt_10",
"unique": false,
"columns": [
"id"
],
"predicate": "(id \u003e 10)"
} |
andrew-farries
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to
create_indexoperations calledpredicate. Whenpredicateis the conditional expression of the partial index. When it is set, pgroll creates a partial index on the table.Example:
{ "name": "37_create_partial_index", "operations": [ { "create_index": { "name": "idx_fruits_id_gt_10", "table": "fruits", "columns": [ "id" ], "predicate": "id > 10" } } ] }Closes #322