8000 style: update paper-card padding to improve readability by gitmarcramos · Pull Request #8 · xBourner/status-card · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

style: update paper-card padding to improve readability #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gitmarcramos
Copy link
Contributor
@gitmarcramos gitmarcramos commented Nov 14, 2024

Hi @xBourner !
First of all, I wanna say a huge thanks for your work! It's really good, and even though I just discovered it yesterday and installed it today, I already love it!

I'm opening this PR because there's a tiny detail that bugs me, and could not get my brain out of it: the padding of the component. I played in the dev tools and I find that a padding of 4px 8xp helps with the general readability, and improves the global layout.

Here's some before/after screenshots:

before
Capture d’écran 2024-11-14 à 21 15 22

after
Capture d’écran 2024-11-14 à 21 15 55

There's maybe some considerations I don't have in mind (smaller screens, phones, lot of displayed entities etc.), but I give it a try.

Cheers :)

@xBourner
Copy link
Owner

nice addition! i really like it.

@xBourner xBourner merged commit 2d95217 into xBourner:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0