10000 Artifact for unit tests by ShreyashKore · Pull Request #143 · xxfast/KStore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Artifact for unit tests #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ShreyashKore
Copy link
@ShreyashKore ShreyashKore commented Mar 5, 2025

Tests are removed as they seem unnecessary. Do we need to support the usage of key?

closes #140

Copy link
Owner
@xxfast xxfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you so much for the PR

Do you think we can name this module kstore-test instead of kstore-testing?

@ShreyashKore
Copy link
Author

Done !

@xxfast
Copy link
Owner
xxfast commented May 11, 2025

Hi. Thank you for the PR! I've commented on #140

Could you clarify what prevents us from using the actual kstore-file in unit test environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an artifact for unit tests
2 participants
0