Decouple dependencies for all connectors except EXCEL and PPT #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8471919
requested changes
Mar 27, 2025
.github/workflows/build.yml
Outdated
Comment on lines
76
to
83
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 # 코드 재체크아웃하여 package.json 확보 | ||
|
|
||
|
|
||
| - name: Download build artifact | ||
| uses: actions/download-artifact@v4 | ||
| with: |
There was a problem hiding this comment.
remove this unnecessary space.
There was a problem hiding this comment.
Could you revert the commit about DallE3? i worked already this.
| * Request to reissue Google access token | ||
| */ | ||
| private async refreshAccessToken(): Promise<string> { | ||
| const client = new google.auth.OAuth2( |
There was a problem hiding this comment.
Add the googleapis dependency to package.json about all the google monorepo packages that use the googleapis package.
There was a problem hiding this comment.
No touch the provider. revert please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the codebase, primarily focusing on removing dependencies on the
@wrtnlabs/connector-aws-s3and@wrtnlabs/connector-googlepackages, and replacing them with shared utilities and direct usage of thegoogleapispackage. Additionally, there are updates to the connectors list and various refactorings to improve code maintainability.Dependency and Service Refactoring:
packages/dall_e_3/package.json: Replaced the@wrtnlabs/connector-aws-s3dependency with@wrtnlabs/connector-shared.packages/dall_e_3/src/dall_e_3/DallE3Service.ts: Removed AWS S3 service usage and replaced it with a utility functionbufferToBase64from@wrtnlabs/connector-shared. [1] [2]packages/dall_e_3/src/structures/IDallE3Service.ts: Removed AWS S3 related properties from the service interface. [1] [2] [3] [4]Google Service Removal and Refactoring:
packages/google/src/google/GoogleService.ts: Removed theGoogleServiceclass which handled Google Auth Service.packages/google/src/index.ts: Removed exports related toGoogleService.packages/google/src/structures/IGoogleService.ts: Removed theIGoogleServicenamespace and its properties.packages/google_ads/src/google_ads/GoogleAdsService.ts: Integrated Google Auth Service directly within theGoogleAdsServiceclass, replacing the removedGoogleService. [1] [2] [3] [4]secretproperty torefreshTokenin Google Ads service tests. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Connectors List Update:
connectors-list.json: Removed@wrtnlabs/connector-googleand@wrtnlabs/connector-image, added@wrtnlabs/connector-youtube-official-searchand@wrtnlabs/connector-youtube-transcript, and updated the version. [1] [2] [3]Workflow Update:
.github/workflows/build.yml: Added blank lines for better readability.