8000 Coverage: fix Selector usage by swissspidy · Pull Request #254 · wp-cli/wp-cli-tests · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Coverage: fix Selector usage #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Coverage: fix Selector usage #254

merged 2 commits into from
May 7, 2025

Conversation

swissspidy
Copy link
Member

Selector class was only added in v9.1 of the php-code-coverage library

Follow-up to #253

Selector class was only added in v9.1 of the php-code-coverage library
@swissspidy swissspidy requested a review from a team as a code owner May 7, 2025 15:14
@swissspidy swissspidy added the bug Something isn't working label May 7, 2025
Copy link
codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/FeatureContext.php 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy
Copy link
Member Author

I successfully tested this PR now in the context of wp-cli/wp-cli-bundle#760 and wp-cli/wp-cli-bundle#761

This should make this finally work

@swissspidy swissspidy added this to the 4.3.16 milestone May 7, 2025
@swissspidy swissspidy merged commit f81af57 into main May 7, 2025
52 checks passed
@swissspidy swissspidy deleted the fix/cov-driver-selector branch May 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0