sui: use implicit Sui framework dependency #4384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 21, 2025 20:26
The previous command assumed gnu grep, which is not distributed (by default) on macs.
To make it a bit easier to identify where things went wrong
these are now automatically added by the compiler, and pinning them to an older version does not actually mean much because on-chain they will be dynamically linked to the latest version anyway. By removing the pinned version here, we allow integrators to also not have to specify the version (or have to override it).
This changes presumably due to changes in the object id assignment logic in the runtime. These are not guaranteed to be consistent between toolchain versions, so we just update to the most recent one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of MystenLabs/sui#21204, the sui move compiler implicitly adds system dependencies when compiling packages. For that behaviour to trigger, we remove the explicit dependency from the various Move.toml files.
This means that integrators no longer need to pin these packages to the same version we use (or override with a newer version). The resulting bytecode will be identical since all the code is dynamically linked to the latest version anyway as system packages are upgraded in-place (https://docs.sui.io/references/sui-api/sui-graphql/reference/types/objects/change-epoch-transaction).