8000 Release 2.7.1: BaseSocketChannel: accept immediately closed socket (#1121) · wolfcon/swift-nio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2.7.1

  • 2.7.1
  • 32760ea
  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
  • Compare
    Choose a tag to compare
  • 2.7.1
  • 32760ea
  • Compare
    Choose a tag to compare
  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@weissi weissi tagged this 24 Aug 11:23
Motivation:

In the grpc-swift test suite, we saw a case where the server would
always immediately close the accepted socket. This lead NIO to misbehave
badly because kqueue would send us the `readEOF` before the `writable`
event that finishes an asynchronous `connect`.

What happened is that we just dropped the `readEOF` on the floor so we
would never actually tell the user if the channel ever went away.

Modifications:

Only register for `readEOF` after becoming active.

Result:

- we're happy with servers that immediately close the socket
Assets 2
Loading
0