8000 [Woo POS] WIP: Experiment Store API usage by iamgabrielma · Pull Request #15619 · woocommerce/woocommerce-ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Woo POS] WIP: Experiment Store API usage #15619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[Woo POS] WIP: Experiment Store API usage #15619

wants to merge 14 commits into from

Conversation

iamgabrielma
Copy link
Contributor
@iamgabrielma iamgabrielma commented May 12, 2025 •
edited
Loading

Closes: #

Description

There's quite a bit of repetition regarding network requests in the experiment above, as well as used URLSession directly rather than our network stack. This is so I could be explicit on what we need for each request and tweak them around as needed, and also to be sure that the Jetpack tunnel (or lack of), and any of our client network details didn't get in the way.

Testing information

  • After creating a cart, tap on checkout
  • Tap on fill cart data
  • Observe the console
✅ Update Payment Method Status: 200
✅ Payment Method Response Body: ...
  • Tap on Pay (COD)
  • Observe the console
✅ Checkout Status: 200
✅ Checkout Response Body: ...
  • Confirm order in store.

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@iamgabrielma iamgabrielma added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 12, 2025
@dangermattic
Copy link
Collaborator
1 Error
🚫 Please ensure the PR has the category: tracks label.
2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
2 Messages
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor
wpmobilebot commented May 12, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29831
VersionPR #15619
Bundle IDcom.automattic.alpha.woocommerce
Commite4302b5
Installation URL04ru6qh4afco0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamgabrielma @dangermattic @wpmobilebot
0