8000 Fix/flaky test 56629 by ralucaStan · Pull Request #58080 · woocommerce/woocommerce · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/flaky test 56629 #58080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 26, 2025
Merged

Fix/flaky test 56629 #58080

merged 27 commits into from
May 26, 2025

Conversation

ralucaStan
Copy link
Contributor
@ralucaStan ralucaStan commented May 16, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fixing the end to end test by waiting for the pickup location to show up in the order summary before placing the order.
I noticed there is a delay between the selection and the data update, this PR fixes the flakiness by making sure the cart is updated.

Closes #56629

How to test the changes in this Pull Request:

Make sure the test does not fail.

Testing that has already taken place:

I re-rerun the tests 3 times, seems to work now.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

ralucaStan added 7 commits May 15, 2025 15:37
@ralucaStan
Update address JS utils to use the addressFieldsForShippingRates setting
b0e141f 
Refactored and renamed the isAddressComplete function to use the shipping fields setting; we're not using it for checking random fields, it was used only for the fields from addressFieldsForShippingRates
Removed some JS utils we weren't using
@ralucaStan
Fix typo
d178f3e
@ralucaStan
add changelog
d86dbe8
@ralucaStan
Add the addressFieldsForShippingRates setting to cart
c15fb21
@ralucaStan
Remove the woocommerce_address_fields_for_shipping_rates filter
b194993 
This was an optimistically added filter. We're not accounting for it in the shipping calculator and the shipping logic isn't account for additional shipping fields
@ralucaStan
Merge branch 'trunk' into update/is-address-complete
f1aee5e
@ralucaStan
Wait for order summary to show the updated pickup selection before pl…
8000
efb45b0 
…acing order
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 16, 2025
@ralucaStan ralucaStan marked this pull request as ready for review May 16, 2025 16:29
@ralucaStan ralucaStan requested review from a team and tjcafferkey and removed request for a team May 16, 2025 16:29
@woocommercebot woocommercebot requested a review from a team May 16, 2025 16:29
@github-actions GitHub Actions
Copy link
Contributor

Testing Guidelines

Hi @tjcafferkey @woocommerce/rubik,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 16, 2025 •
edited
Loading

Size Change: -120 B (0%)

Total Size: 5.96 MB

compressed-size-action

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 16, 2025 •
edited
Loading

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

ralucaStan added 8 commits May 26, 2025 15:13
@ralucaStan
Update address JS utils to use the addressFieldsForShippingRates setting
7a5cdfe 
Refactored and renamed the isAddressComplete function to use the shipping fields setting; we're not using it for checking random fields, it was used only for the fields from addressFieldsForShippingRates
Removed some JS utils we weren't using
@ralucaStan
Fix typo
6bca9cb
@ralucaStan
add changelog
696ca85
@ralucaStan
Add the addressFieldsForShippingRates setting to cart
9330d8c
@ralucaStan
Remove the woocommerce_address_fields_for_shipping_rates filter
ed4ac88 
This was an optimistically added filter. We're not accounting for it in the shipping calculator and the shipping logic isn't account for additional shipping fields
@ralucaStan
Wait for order summary to show the updated pickup selection before pl…
a364383 
…acing order
@ralucaStan
Fix label
7f856ac
@ralucaStan
add changelog
c10267a
@ralucaStan ralucaStan force-pushed the fix/flaky-test-56629 branch from d04b95e to c10267a Compare May 26, 2025 13:13
ralucaStan added 8 commits May 26, 2025 15:17
@ralucaStan
Revert "Remove the woocommerce_address_fields_for_shipping_rates filter"
65aac0f 
This reverts commit b194993.
@ralucaStan
Merge branch 'fix/flaky-test-56629' of github.com:woocommerce/woocomm…
a847057 
…erce into fix/flaky-test-56629

# Conflicts:
#	plugins/woocommerce/src/Blocks/BlockTypes/Checkout.php
@ralucaStan
Revert "Remove the woocommerce_address_fields_for_shipping_rates filter"
047a6d8 
This reverts commit ed4ac88.
@ralucaStan
Revert "Add the addressFieldsForShippingRates setting to cart"
d06521d 
This reverts commit c15fb21.
@ralucaStan
Revert "Update address JS utils to use the addressFieldsForShippingRa…
9388e2c 
…tes setting"

This reverts commit 7a5cdfe.
@ralucaStan
Revert "add changelog"
0008949 
This reverts commit d86dbe8.
@ralucaStan
Revert "Fix typo"
a7e8e99 
This reverts commit d178f3e.
@ralucaStan
Merge branch 'trunk' into fix/flaky-test-56629
5d5252c
@ralucaStan ralucaStan merged commit 921b01c into trunk May 26, 2025
29 checks passed
@ralucaStan ralucaStan deleted the fix/flaky-test-56629 branch May 26, 2025 14:36
@github-actions github-actions bot added this to the 10.0.0 milestone May 26, 2025
samueljseay pushed a commit that referenced this pull request May 27, 2025
@ralucaStan @samueljseay
Fix/flaky test 56629 (#58080)
7755a91 
Fix the end-to-end test by waiting for the pickup location to appear in the order summary before placing the order.
vladolaru pushed a commit that referenced this pull request May 28, 2025
@ralucaStan @vladolaru
Fix/flaky test 56629 (#58080)
841e5d4 
Fix the end-to-end test by waiting for the pickup location to appear in the order summary before placing the order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjcafferkey tjcafferkey tjcafferkey approved these changes

Assignees
No one assigned
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Switching between local pickup and shipping does not affect the address and is used for the order
2 participants
@ralucaStan @tjcafferkey
0