8000 Add Tags to product editor by octaedro · Pull Request #39966 · woocommerce/woocommerce · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Tags to product editor #39966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 6, 2023
Merged

Add Tags to product editor #39966

merged 21 commits into from
Sep 6, 2023

Conversation

octaedro
Copy link
Contributor
@octaedro octaedro commented Aug 30, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR introduces Tags handling to the blocks editor, enhancing the user's experience while handling products. Users can now create, add, remove, and search for existing tags. This process mirrors the way we currently manage Categories.

Screenshot 2023-09-01 at 09 28 53

Closes #39126.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the product blocks editor under WooCommerce -> Settings -> Advanced -> Features.
  2. Navigate to Products > Add new.
  3. Press Organization and select the Tags dropdown menu.
  4. You'll see the tags that you already had.
  5. Press Create new and add the name of a new tag.
  6. After a brief moment, the new tag should appear in both the dropdown menu and the input field.

Screen Capture on 2023-09-01 at 10-06-24

  1. While still within the Tags selector, start typing the name of a new tag.
  2. Press Create [tag name that you typed].
  3. After a few seconds, the new tag should be added to the selector.

Screen Capture on 2023-09-01 at 10-11-47

  1. To ensure proper functionality, verify that the tags are saved correctly, both individually and when assigned to a product.

// cc @jarekmorawski I've mirrored the Categories selector behavior. Could you check whether the tags selector looks and functions as expected?

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 30, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Aug 30, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 9f3448b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 20s
E2E Tests1950015021023m 15s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro changed the title Add/39126 add tags to product editor Add Tags to product editor Aug 31, 2023
@octaedro octaedro self-assigned this Aug 31, 2023
@octaedro octaedro marked this pull request as ready for review September 1, 2023 13:43
@octaedro octaedro requested a review from a team September 1, 2023 13:43
@github-actions
Copy link
Contributor
github-actions bot commented Sep 1, 2023 •
edited
Loading

Hi @mdperez86,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the package: @woocommerce/components issues related to @woocommerce/components label Sep 1, 2023
mdperez86
mdperez86 previously requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor
@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octaedro Big job here! I left some comments.

@octaedro octaedro force-pushed the add/39126_add_tags_to_product_editor branch from 51d9c2a to 0ea2f31 Compare September 6, 2023 13:49
@octaedro
Copy link
Contributor Author
octaedro commented Sep 6, 2023

Thank you @mdperez86 for reviewing this PR.
I addressed the suggestions you made. Could you give this PR another look?

@octaedro octaedro requested a review from mdperez86 September 6, 2023 13:50
mdperez86
mdperez86 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor
@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here @octaedro LGTM!!!

@octaedro octaedro merged commit ad1920c into trunk Sep 6, 2023
@octaedro octaedro deleted the add/39126_add_tags_to_product_editor branch September 6, 2023 18:51
@github-actions github-actions bot added this to the 8.2.0 milestone Sep 6, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Sep 6, 2023
@rodelgc rodelgc added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Sep 7, 2023
@rodelgc
Copy link
Contributor
rodelgc commented Sep 7, 2023

Labeling this for internal testing and high impact because of the great number of changes contained in the PR.

@rodelgc rodelgc added the impact: high To be added by the PR author/reviewer if the PR could very likely cause SEV-1 or SEV-2 issues label Sep 7, 2023
This was referenced Sep 7, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdperez86 mdperez86 mdperez86 approved these changes

Assignees
< 6293 span class="css-truncate js-issue-assignees">

@octaedro octaedro

Labels
impact: high To be added by the PR author/reviewer if the PR could very likely cause SEV-1 or SEV-2 issues needs: internal testing Indicates if the PR requires further testing conducted by Solaris package: @woocommerce/components issues related to @woocommerce/components package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

[Product Block Editor] Add tags (or general taxonomy ) block
3 participants
@octaedro @rodelgc @mdperez86
0