Add exclusion for /vendor directory in zip build
#2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composer archive previously included the /vendor directory where the .gitignore excluded it. This adjusts the composer archive exclude array to omit the /vendor directory from the zip generation.
5076ee6 to
2e20f47
Compare
Aljullu
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
LGTM, thanks for creating the PR, @danielwrobert!
I followed the testing steps and did some smoke testing with the generated ZIP and everything seems to be working well.
nefeline
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
composer archivecommand previously included the/vendordirectory where the.gitignorefile excludes it.This adjusts the exclude array in the
composer.jsonfile to omit the/vendordirectory from the zip generation.See this internal conversation for additional context: p1689174493505199-slack-C7U3Y3VMY.
Props to @danieldudzic for discovering the discrepancy!
Screenshots
How to test the changes in this Pull Request:
composer installcommand which will generate a/vendorfolder in the root directory.npm run buildand confirm thestorefront.zipfile is generated./vendorfolder present in the root directory of the theme.Changelog