Fix incrorrect build of 2t-to-1
#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The file is automatically generated from Line 52 in 1f6e4fb B there, and run npm test to build everything?
|
terminologic code keys were actually bibliographic codes
|
Oh sorry, I completely missed that there's a build file. I fixed the part you suggested and ran the build + tests. Should be good now. |
wooorm
approved these changes
Jul 23, 2022
2t-to-1
|
Thank you! Released in 3.0.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wooorm, thanks for the library,
I noticed that some languages were missing, but then I realized that the issue was just some wrong keys in a file, more specifically terminologic keys were actually the bibliographic ones in the file
2t-to-1.js.I fixed and sorted them.