Add RtBrick mode #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfokus
reviewed
Apr 29, 2025
Comment on lines
+156
to
+161
| # name contains an ip version suffix every time. | ||
| shorted_name = self.name | ||
| if len(self.name) > 32: | ||
| as_len = len(str(self.asn)) | ||
| cap = 29 - as_len - 1 | ||
| shorted_name = f'{self.name[0:-3][:cap]}_{str(self.asn)}{self.name[-3:]}' |
There was a problem hiding this comment.
Afaik rtbrick does not have limitations for peer-group name length. But it might make sense to stay consistent and use the same group names on both platforms. In that case the logic should be separated, to reduce duplicate code
Comment on lines
+179
to
+184
| # TODO | ||
| # if self.bfd_infos: | ||
| # rtbrick_elem['bfd'] = { | ||
| # "min_interval": self.bfd_infos['min_interval'], | ||
| # "multiplier": self.bfd_infos['multiplier'], | ||
| # } |
There was a problem hiding this comment.
rtbrick does not support binding BFD to BGP sesssion yet. Perhaps we should throw a warning when it is attempted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.