Initialize ai model when needed in canvas #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors AI model initialization in the canvas to defer loading until needed by storing just the model name and retrieving the model via a cached helper function.
- Removed direct model instance storage (
self._sam) and initialization calls. - Introduced
set_ai_model_nameto update the selected model name. - Added
_get_ai_modelwithlru_cachefor on-demand model instantiation. - Updated UI event handlers in
app.pyto use the new model naming API.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| labelme/widgets/canvas.py | Replaced eager model init with storing model name and _get_ai_model helper; removed initializeAiModel. |
| labelme/app.py | Updated combo-box signals to call set_ai_model_name; removed old init connectors and reordered index setting. |
Comments suppressed due to low confidence (3)
labelme/widgets/canvas.py:135
- [nitpick] Method names in this class use camelCase; consider renaming
set_ai_model_nametosetAiModelNamefor consistency.
def set_ai_model_name(self, model_name: str) -> None:
labelme/widgets/canvas.py:1035
- This helper is public to the module but lacks a docstring. Add a brief description of its purpose, parameters, and return behavior.
def _get_ai_model(model_name: str) -> osam.types.Model:
labelme/widgets/canvas.py:135
- The new
set_ai_model_namemethod and caching logic lack unit tests. Consider adding tests to verify that the model name is updated correctly and that_get_ai_modelreturns and caches the right model instance.
def set_ai_model_name(self, model_name: str) -> None:
|
Grt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
self._samanymore