Test polygon creation in test app py #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e44e687 to
279ddde
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds and refactors tests in the test app for polygon creation, helping prevent regression issues like those mentioned in the linked PR. Key changes include:
- Renaming the helper function for showing the window and waiting for image data.
- Adding type hints and annotations to test functions.
- Introducing an expanded test for polygon creation in images.
Comments suppressed due to low confidence (1)
tests/labelme_tests/test_app.py:81
- In test_MainWindow_openPrevImg, the method openNextImg() is used instead of openPrevImg(), which may not correctly test the intended functionality. Consider updating the call to win.openPrevImg() if testing the previous image functionality is intended.
win.openNextImg()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
So that we can prevent an issue like: #1566