Don’t set defaults for attrs and content in head entries
#3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 844f0ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
size-limit report 📦
|
HiDeoo
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Amazing, was planning to do this during lunch after noticing it while updating guides on my website for Starlight 0.33 but you already did it 🎉 🙌
Looks perfect to me, easier for users, easier for us in our tests, only wins all around.
I'll just have to update my guides again 😄
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Apr 16, 2025
* main: [ci] release (withastro#3124) Fix E2E tests broken by formatter [ci] format Add built-in heading anchor link support (withastro#3033) i18n(fr): update `environmental-impact` (withastro#3123) Cascade Layers (withastro#2322) Fix image metadata validation in StarlightPage schema (withastro#3118) Don’t set defaults for `attrs` and `content` in head entries (withastro#3122) [ci] format i18n(es) Translate `route-data` (withastro#3071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attrsandcontentfrom the schema used to parse head entries (previously these were{}and""respectively).headarray without types saying you must set these default values.headin some way, although for the average site this should be basically an internal API change.headby linking toHeadConfig, which shows these properties as optional.