LG-71 Respond to SetScratchpadTargetAndActionReq with invalid parameters #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike most of the other messages, parameter validation for SetScratchpadTargetAndActionReq is done on the wirepas-mesh-messaging library side and not in transport service. Before this change, from_payload() method would raise an exception in those cases, but a response could not be sent because the req_id was not known. Newer version of the wirepas-mesh-messaging library raises an InvalidMessageContents exception which includes the request header, so it is possible to build a response message.
GwendalRaoul
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike most of the other messages, parameter validation for SetScratchpadTargetAndActionReq is done on the wirepas-mesh-messaging library side and not in transport service.
Before this change, from_payload() method would raise an exception in those cases, but a response could not be sent because the req_id was not known. Newer version of the wirepas-mesh-messaging library raises an InvalidMessageContents exception which includes the request header, so it is possible to build a response message.